Skip to content

address unsafe list mutation during iteration and bypasses exception …#1669

Open
fujitatomoya wants to merge 2 commits into
rollingfrom
fujitatomoya/issues/1665
Open

address unsafe list mutation during iteration and bypasses exception …#1669
fujitatomoya wants to merge 2 commits into
rollingfrom
fujitatomoya/issues/1665

Conversation

@fujitatomoya

@fujitatomoya fujitatomoya commented May 18, 2026

Copy link
Copy Markdown
Collaborator

…re-raise.

Description

i was checking the #1665, and found this.

Fixes # (issue)

Is this user-facing behavior change?

Not really, should only gets better.

Did you use Generative AI?

Yes, Claude Opus 4.7

Additional Information

@fujitatomoya

fujitatomoya commented May 18, 2026

Copy link
Copy Markdown
Collaborator Author

@nadavelkabets can i have your review on this?

@fujitatomoya fujitatomoya mentioned this pull request May 18, 2026
Closed
nadavelkabets
nadavelkabets approved these changes May 19, 2026
View reviewed changes

@nadavelkabets nadavelkabets left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with 2 small comments

Comment thread rclpy/rclpy/executors.py
Comment thread rclpy/rclpy/executors.py Outdated
@fujitatomoya

fujitatomoya commented May 20, 2026 •
edited by christophebedard
Loading

Copy link
Copy Markdown
Collaborator Author

Pulls: #1669
Gist: https://gist.githubusercontent.com/fujitatomoya/af3b4f3d966ddf21572e73e9030f2678/raw/2c5afceaa94e58b257318b91095b48b684eaa8a1/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19326

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard

christophebedard commented May 21, 2026

Copy link
Copy Markdown
Member

Could the Windows test failures be related?

@fujitatomoya

fujitatomoya commented May 21, 2026

Copy link
Copy Markdown
Collaborator Author

No i do not think so.

@fujitatomoya

fujitatomoya commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

@Mergifyio rebase

@fujitatomoya
address unsafe list mutation during iteration and bypasses exception …
af1db55 
…re-raise.

Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
@fujitatomoya
cover cancelled future along with done ones.
e71758a 
Signed-off-by: Tomoya Fujita <tomoya.fujita825@gmail.com>
@mergify

mergify Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

rebase

✅ Branch has been successfully rebased

@fujitatomoya fujitatomoya force-pushed the fujitatomoya/issues/1665 branch from d5b53d2 to e71758a Compare June 4, 2026 22:42
@fujitatomoya

fujitatomoya commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

Pulls: #1669
Gist: https://gist.githubusercontent.com/fujitatomoya/4f5db656a5f9f7dd51cbf08b734db4f2/raw/2c5afceaa94e58b257318b91095b48b684eaa8a1/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19482

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nadavelkabets nadavelkabets nadavelkabets approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@fujitatomoya fujitatomoya

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fujitatomoya @christophebedard @nadavelkabets