Skip to content

Fix incorrect action client/server callback type hints (backport #1616)#1655

Open
bjsowa wants to merge 2 commits into
ros2:kiltedfrom
bjsowa:backport/kilted/action-type-hints
Open

Fix incorrect action client/server callback type hints (backport #1616)#1655
bjsowa wants to merge 2 commits into
ros2:kiltedfrom
bjsowa:backport/kilted/action-type-hints

Conversation

@bjsowa

@bjsowa bjsowa commented Apr 22, 2026

Copy link
Copy Markdown
Contributor

Backport of #1616 to Kilted

@bjsowa bjsowa force-pushed the backport/kilted/action-type-hints branch from 05e2585 to f29c93d Compare April 22, 2026 18:28
@bjsowa bjsowa mentioned this pull request Apr 22, 2026
Closed
bjsowa and others added 2 commits April 22, 2026 22:48
@bjsowa @laser
Fix incorrect action client/server callback type hints (backport ros2…
d3a2c31 
…#1616)

Signed-off-by: Błażej Sowa <bsowa123@gmail.com>
Co-authored-by: Laser <l@s3r.me>
@bjsowa
Fix flake8 errors
06d0cef 
Signed-off-by: Błażej Sowa <bsowa123@gmail.com>
@bjsowa bjsowa force-pushed the backport/kilted/action-type-hints branch from f29c93d to 06d0cef Compare April 22, 2026 20:48
@fujitatomoya

fujitatomoya commented Apr 23, 2026

Copy link
Copy Markdown
Collaborator

@InvincibleRMC can you review this?

@InvincibleRMC

InvincibleRMC commented May 9, 2026

Copy link
Copy Markdown
Contributor

Pulls: #1655
Gist: https://gist.githubusercontent.com/InvincibleRMC/2edcb06ac0761001d4fd118e89682a60/raw/aa96a449c720636b2d01984860801f41dbbc40b1/ros2.repos
BUILD args: --continue-on-error --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19204

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@bjsowa

bjsowa commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Can we get this merged?

@fujitatomoya

fujitatomoya commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Not yet, CI needs to be green. let me try to restart.

@fujitatomoya

fujitatomoya commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Pulls: #1655
Gist: https://gist.githubusercontent.com/fujitatomoya/bbca5bdc7f778b21f4b645ff6df2cc51/raw/aa96a449c720636b2d01984860801f41dbbc40b1/ros2.repos
BUILD args: --packages-above-and-dependencies rclpy
TEST args: --packages-above rclpy
ROS Distro: kilted
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/19458

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@bjsowa

bjsowa commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

The CI failures don't seem related to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@InvincibleRMC InvincibleRMC InvincibleRMC approved these changes

Assignees

@InvincibleRMC InvincibleRMC

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bjsowa @fujitatomoya @InvincibleRMC