Skip to content

Switching to example_interfaces#674

Merged
sloretz merged 4 commits into
ros2:rollingfrom
CursedRock17:example_interfaces
Jan 15, 2026
Merged

Switching to example_interfaces#674
sloretz merged 4 commits into
ros2:rollingfrom
CursedRock17:example_interfaces

Conversation

@CursedRock17

@CursedRock17 CursedRock17 commented May 1, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request solves the demos side of this ros2_documentation issue in which we switch from std_msgs to example_interfaces because std_msgs was deprecated about 4 years ago.

@CursedRock17
Switching to example_interfaces
3bf2665 
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
@CursedRock17
Fixing cpplint
578b01f 
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
@CursedRock17
Slight cpplint error
c2becea 
Signed-off-by: CursedRock17 <mtglucas1@gmail.com>
fujitatomoya
fujitatomoya approved these changes May 1, 2024
View reviewed changes

@fujitatomoya fujitatomoya left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm with green CI

Comment thread demo_nodes_cpp/src/topics/talker.cpp
// (rclcpp::KeepLast(7) -> rclcpp::KeepAll() fails to compile)
rclcpp::QoS qos(rclcpp::KeepLast{7});
pub_ = this->create_publisher<std_msgs::msg::String>("chatter", qos);
pub_ = this->create_publisher<example_interfaces::msg::String>("chatter", qos);

@fujitatomoya fujitatomoya May 1, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should resolve ros2/examples#377 (comment)

ahcorde
ahcorde approved these changes May 8, 2024
View reviewed changes

@ahcorde ahcorde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@ahcorde
Merge branch 'rolling' into example_interfaces
0f1e71e 
Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde

ahcorde commented Oct 2, 2025

Copy link
Copy Markdown
Contributor

Pulls: #674
Gist: https://gist.githubusercontent.com/ahcorde/647d48e78542fa5bb1ad866e1ae5c07e/raw/bb2f4f496dd3a37c054d22668ba05be17a06e6a1/ros2.repos
BUILD args: --packages-above-and-dependencies composition demo_nodes_cpp demo_nodes_cpp_native demo_nodes_py image_tools intra_process_demo lifecycle lifecycle_py logging_demo quality_of_service_demo_cpp topic_monitor topic_statistics_demo
TEST args: --packages-above composition demo_nodes_cpp demo_nodes_cpp_native demo_nodes_py image_tools intra_process_demo lifecycle lifecycle_py logging_demo quality_of_service_demo_cpp topic_monitor topic_statistics_demo
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17152

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@audrow audrow removed their request for review January 5, 2026 15:20
@sloretz

sloretz commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Pulls: #674
Gist: https://gist.githubusercontent.com/sloretz/27a9a0e32e0dd8fcfec7fe6153a93bf6/raw/fa3d0b8a181b5e1656227be37db3ca52130e849d/ros2.repos
BUILD args: --packages-above-and-dependencies action_tutorials_cpp action_tutorials_py composition demo_nodes_cpp demo_nodes_cpp_native demo_nodes_py dummy_map_server dummy_robot_bringup dummy_sensors image_tools intra_process_demo lifecycle lifecycle_py logging_demo pendulum_control pendulum_msgs quality_of_service_demo_cpp quality_of_service_demo_py topic_monitor topic_statistics_demo
TEST args: --packages-above action_tutorials_cpp action_tutorials_py composition demo_nodes_cpp demo_nodes_cpp_native demo_nodes_py dummy_map_server dummy_robot_bringup dummy_sensors image_tools intra_process_demo lifecycle lifecycle_py logging_demo pendulum_control pendulum_msgs quality_of_service_demo_cpp quality_of_service_demo_py topic_monitor topic_statistics_demo
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17970

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@sloretz

sloretz commented Jan 15, 2026

Copy link
Copy Markdown
Contributor

Thank you for the PR!

@sloretz sloretz merged commit 59c25b8 into ros2:rolling Jan 15, 2026
3 checks passed
@SuperJappie08 SuperJappie08 mentioned this pull request Jan 16, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

@fujitatomoya fujitatomoya fujitatomoya approved these changes

@adityapande-1995 adityapande-1995 Awaiting requested review from adityapande-1995

@mjeronimo mjeronimo Awaiting requested review from mjeronimo

Assignees

@sloretz sloretz

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@CursedRock17 @ahcorde @sloretz @fujitatomoya