Refactor Runnable with name, formatter, and hooks#26
Merged
Conversation
6cb834e to
dcdc38d
Compare
5 tasks
23dbc74 to
4db2d42
Compare
ad45966 to
1523685
Compare
PerezIgnacio
approved these changes
Mar 2, 2026
Base automatically changed from
santib/execution-context-formatter-hooks
to
main
March 4, 2026 15:10
Phase 2 of the Mars v2 refactor. - Runnable: include Hooks, add `name` (auto-derived from class via `step_name`), add `formatter` class-level DSL with instance fallback - Gate, Aggregator, Sequential, Parallel: delegate `name` to Runnable via super instead of managing their own attr_reader - Runnable spec: cover name derivation, formatter DSL, hooks integration Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1523685 to
c08b53a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hooks, has anameattribute (auto-derived from class name viastep_name), and aformatterclass-level DSL with instance-level overridenameto Runnable's constructor instead of managing their ownattr_reader :namePhase 2 of the v2 refactor. Depends on #24 (ExecutionContext, Formatter, Hooks).
Test plan
MyCustomStep→my_custom_step)Mars::Formatter, respects class-level DSL and instance overridebefore_run/after_runwork on any Runnable🤖 Generated with Claude Code