Draft
Conversation
Also change the condition: only not to install on Android since Android doesn't support pkgconfig yet.
Also rename option BUILD_STATIC to WITH_STATIC_DEPS to make people more aware of its role
So that we are able to link them by their namespace/target name
# Conflicts: # .github/workflows/windows-build.yml # CMakeLists.txt # build-clang.bat # cmake/FindYamlCpp.cmake # src/rime/setup.cc # test/CMakeLists.txt
# Conflicts: # .github/workflows/windows-build.yml # CMakeLists.txt # build-clang.bat # cmake/FindYamlCpp.cmake # src/rime/setup.cc # test/CMakeLists.txt
# Conflicts: # CMakeLists.txt
This reverts commit 2ec7f93.
This reverts commit 2968aed.
This reverts commit 9ae4390.
…get and streamline public dependencies
… definitions for libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request
based on #749
Issue tracker
Fixes will automatically close the related issue
Fixes #
Feature
Rime::rimetarget for library consumers, with old variables keptBUILD_TESTINGoptionUnit test
Manual test
Code Review
Additional Info
I plan to introduce
vcpkgas package manager and remove many platform-specific scripts for vendored-dependency handling, but I don't know whether that's acceptable for merge.