fix(codegen): manual switch table configuration in block discovery#370
Open
Graine25 wants to merge 1 commit into
Open
fix(codegen): manual switch table configuration in block discovery#370Graine25 wants to merge 1 commit into
Graine25 wants to merge 1 commit into
Conversation
Graine25
force-pushed
the
jumptable-codegen
branch
from
b41628c to
be7d32d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The manually configured switch tables in the config weren't being passed into
discoverBlocks()at all. The call site inphase_discover.cppsimply didn't forwardctx.Config().switchTables.The fix adds a manualSwitchTables parameter to
discoverBlocks()so that user-configured tables (fromctx.Config().switchTables) take priority over auto-detection at each bcctr address. It also adds a guard ->if (t != entryPoint && knownFunctions.contains(t)) continue;<- to prevent jump table targets that land at the start of a known function from being incorrectly imported as basic blocks of the current function (i.e., tail dispatch is now handled correctly).