Improve timeouts handling to make sure Node processes are not hanging#107
Open
katafrakt wants to merge 1 commit into
Open
Improve timeouts handling to make sure Node processes are not hanging#107katafrakt wants to merge 1 commit into
katafrakt wants to merge 1 commit into
Conversation
This improves how timeouts are handles by: - Removing the race condition from where timeout originates - now it's always coming from GenServer.call - Killing the process on timeout, so the next time the worker is checked out from the pool, it for sure has a fresh and working timeout - Replacing returning strings in error tuples with an atom
|
+1 — we hit this exact The catch-all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to #102 with improvements suggested there in the closing comment.
This improves how timeouts are handles by:
GenServer.call