fix: fully qualify Box::pin in ServiceGenerator#111
Merged
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
tillrohrmann
approved these changes
May 11, 2026
tillrohrmann
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for creating this PR @MohamedBassem. LGTM. Merging this now :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋
Was playing with a toy sandbox implementation baked by restate, and had a struct named
Box(terrible name in the rust world, I know). This, however, uncovered an unqualified call toBox::pinin the service generator. So this tiny PR fixes that for better macro hygiene.Repro
In the examples dir, add a struct named
Boxin any of the files:and the compiler will complain:
After qualifying the call, it compiles and tests are passing.