fix: avoid mutating payloads in emails, broadcasts, and templates#862
Open
Shubhdeep12 wants to merge 3 commits intoresend:canaryfrom
Open
fix: avoid mutating payloads in emails, broadcasts, and templates#862Shubhdeep12 wants to merge 3 commits intoresend:canaryfrom
Shubhdeep12 wants to merge 3 commits intoresend:canaryfrom
Conversation
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
gabrielmfern
changed the title
gabrielmfern
reviewed
Mar 2, 2026
| expect(mockRenderAsync).toHaveBeenCalledWith(mockReactComponent); | ||
| }); | ||
|
|
||
| it('does not mutate payload when using React component', async () => { |
Member
There was a problem hiding this comment.
can you also add tests to email.ts and @broadcasts.ts for this?
Contributor
Author
There was a problem hiding this comment.
added. thanks for review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Stop mutating request payloads in emails, broadcasts, and templates when rendering React to HTML. This prevents side effects and keeps input objects unchanged.
Written for commit c6dcfb4. Summary will update on new commits.