fix(preview-server): detect hsl/hsla colors in compatibility checker#3061
Open
mvanhorn wants to merge 1 commit intoresend:canaryfrom
Open
fix(preview-server): detect hsl/hsla colors in compatibility checker#3061mvanhorn wants to merge 1 commit intoresend:canaryfrom
mvanhorn wants to merge 1 commit intoresend:canaryfrom
Conversation
Adds supplemental support entries for hsl() and hsla() CSS color functions. Microsoft Outlook on Windows does not support these color values, but the compatibility checker had no way to flag them since caniemail.com does not track hsl/hsla support. The supplemental data is in a separate file so it won't be overwritten when the caniemail data is refreshed via fill-caniemail-data.mts. Fixes resend#2947 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
@mvanhorn is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
|
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The email compatibility checker now flags
hsl()andhsla()color values as unsupported in Microsoft Outlook on Windows.Previously, these color functions were invisible to the checker because caniemail.com does not track hsl/hsla support data. Users would unknowingly use hsl colors that render correctly in the preview but fail silently in Outlook (Word rendering engine).
Fixes #2947
Changes
caniemail-supplemental-data.ts- Contains manually curated support entries forhsl()andhsla()with Outlook Windows marked as unsupported ("n"). Kept separate from the auto-generatedcaniemail-data.tsso entries survive re-runs offill-caniemail-data.mts.check-compatibility.ts- Merges supplemental entries with the caniemail data so the existing CSS function matching logic picks up hsl/hsla automatically.Why a separate file?
The
caniemail-data.tsfile is auto-generated from caniemail.com's API viafill-caniemail-data.mts. Adding entries directly would get wiped on the next refresh. The supplemental file can be removed once caniemail.com adds official hsl/hsla tracking.This contribution was developed with AI assistance (Claude Code).
Summary by cubic
Flags
hsl()andhsla()colors as unsupported in Outlook on Windows in the email compatibility checker to prevent silent rendering failures. Fixes Linear issue #2947.hsl()/hsla()with Outlook Windows marked as unsupported, kept incaniemail-supplemental-data.ts.caniemailentries incheck-compatibility.tsso existing CSS function detection catches these colors.Written for commit cca134f. Summary will update on new commits.