Make TDateTime a record so that it can be automatically converted to the native DateTime type under Echoes#70
Open
obones wants to merge 1 commit intoremobjects:masterfrom
Open
Conversation
…the native DateTime type under Echoes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The assemblies I'm writing are used by C# users and because
TDateTimeis just an alias forDouble, all they can see is aDoubleparameter/property/value when working with my Oxygene assemblies.This pull request changes
TDateTimeto be a record that implicitly converts to and fromDoublealong with an implicit conversion to and fromDateTimewhen compiled for Echoes.Note that its internal
Valueneeds to be public so that advanced usages not covered by operators is still possible.