ci: fix fork GitDepWithLampe handling and stdlib cache production#293
Merged
Conversation
Eduardogbg
force-pushed
the
edu/ci-fork-cache-fixes-pr
branch
from
c9413a0 to
3eb221c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
GitDepWithLampe-*revisions in extracted lakefiles during CIwhy
the existing CI test harness rewrites
GitDepWithLampe-*requirements to the current branch/ref. That breaks fork PRs because the generated lakefile still points athttps://github.com/reilabs/lampewhile the branch name only exists in the fork.the stdlib cache was also being produced by copying
.lake/buildout of a temp extraction run. This changes CI to validate extraction first, then produce the reusable stdlib cache from an in-placestdlib/lampebuild using the shared Lake package cache.validation