metamod: remove -s strip flag to preserve linker markers - #93
Open
blshkv wants to merge 1 commit into
Open
Conversation
The -s flag causes `strip` to run on the output binary, which removes all symbols including sentinel symbols used by packaging systems (e.g. Gentoo's __gentoo_check_ldflags__) to verify that LDFLAGS were respected. Remove the flag so that stripping is left to the build system / packager.
blshkv
added a commit
to blshkv/ReGameDLL_CS
that referenced
this pull request
Aug 13, 2026
The -s flag strips all symbols from the output shared library, including sentinel symbols used by packaging systems to verify LDFLAGS were respected (e.g. Gentoo's __gentoo_check_ldflags__). Same issue fixed in the sibling project: rehlds/Metamod-R#93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
-sflag inLINK_FLAGSinside the non-debug branch causesstripto run on the output shared library, which removes all symbols from the binary — including sentinel symbols used by packaging systems to verify thatLDFLAGSwere respected.For example, Gentoo injects
--defsym=__gentoo_check_ldflags__=0intoLDFLAGSand then checks that the resulting binary still contains__gentoo_check_ldflags__after linking. The-sstrip pass removes it, causing a QA failure:Stripping should be left to the build system or packager (e.g. via
INSTALL_STRIP_FLAGorCMAKE_INSTALL_DO_STRIP), not hardcoded into link flags.Change
Remove
set(LINK_FLAGS "${LINK_FLAGS} -s")from the non-debug branch inmetamod/CMakeLists.txt.