Re-writing accessors transformer using the new AGP API by nhachicha · Pull Request #7694 · realm/realm-java

nhachicha · 2022-06-30T16:34:05Z

Migrating the Realm accessor Transformer to use the new AHP transformer API
Migrated Gradle plugin from Groovy to Kotlin.
Re-writing the internal object server transformer

iamkingalvarado · 2022-07-22T05:28:50Z

dependencies.list

 ANDROID_BUILD_TOOLS=30.0.3
-KOTLIN=1.5.31
-KOTLIN_COROUTINES=1.5.2
+KOTLIN=1.6.20


Probably you can try 1.7 as is the latest stable available

iamkingalvarado · 2022-07-22T05:29:36Z

examples/gradle/wrapper/gradle-wrapper.properties

 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.3.3-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-bin.zip


7.5 is also available

nhachicha · 2022-07-27T09:23:04Z

@rorbech I updated the current WIP

Currently, the JNI generated header files (.h) are not created if we invoke assemble, this might be caused by the various bumps to Gradle and AGP ... if you run compileBaseReleaseJavaWithJavac for instance then it will compile and generate the headers.
The internal transformer (the one that strips the ObjectServer symbols) needs to be re-written similarly to the accessor one.
I updated some tests projects to run the new transformer against them
We need to create a feature branch and release from it (probably using this template [DO NOT MERGE] manual release to maven central #7704

For reference:

https://issuetracker.google.com/issues/237190740#comment4

…mes (#7711)

rorbech · 2022-08-31T10:35:48Z

I manually verified that all our examples are running with the current state. Also verified that updating model and other sources is properly rebuilt in incremental builds for a couple of the examples.

Update config.yml

Remove export compliance clause

cmelchior

Awesome work 🥇 🕺 ... As I don't really know the new transform API it was a bit hard to track some of the changes, but if all our sample projects are building and tests are running, I think we can assume that things are working 🥳

I only left some minor comments.

...s/architectureComponentsExample/src/main/java/io/realm/examples/arch/PersonListFragment.java

realm/realm-library/src/main/java/io/realm/internal/objectstore/OsMutableSubscriptionSet.java

realm/realm-library/src/main/java/io/realm/internal/objectstore/OsSubscription.java

gradle-plugin/src/main/templates/Version.kt

cmelchior · 2022-09-09T09:09:32Z

library-build-transformer/src/main/kotlin/io/realm/buildtransformer/RealmBuildTransformer.kt

+        val metadataCollector =
+            io.realm.buildtransformer.asm.visitors.AnnotationVisitor(annotationDescriptor)
+
+        forEachJarEntry { jarEntry, inputStream ->


It is a bit unclear why we iterate the jar entries twice, some documentation for each block would be nice.

Added some comments

cmelchior · 2022-09-09T09:12:51Z

library-build-transformer/src/main/kotlin/io/realm/buildtransformer/RealmBuildTransformer.kt

-                    return@iterateDirs // Directory was deleted
+        forEachJarEntry { jarEntry, inputStream ->
+            val bytes = inputStream.use { inputStream ->
+                if (jarEntry.name.endsWith(".class")) {


What happens with ressource files in the JAR? We seem to skip them here, but I'm not sure how they then end up in the outputprovider?

They are handled by the else branch 🎉 🤪

cmelchior · 2022-09-09T09:35:49Z

realm-transformer/src/main/kotlin/io/realm/transformer/RealmTransformer.kt

    private lateinit var metadata: ProjectMetaData
    private var analytics: RealmAnalytics? = null

    init {


Same, running all of this logic directly in the constructor feels ...iffy

Same, I just exposed transform as internal and call it on the constructed object instead of implicitly from the init-block.

realm-transformer/src/main/kotlin/io/realm/transformer/RealmTransformer.kt

cmelchior · 2022-09-09T09:41:50Z

realm-transformer/src/main/kotlin/io/realm/transformer/build/BuildTemplate.kt

-        classPool.close();
+    fun copyProcessedClasses() {
+        for ((fqname: String, clazz: CtClass) in processedClasses) {
+            outputProvider.putNextEntry(JarEntry("${fqname.replace('.', '/')}.class"))


Does this also work on Windows or should we use File.separatorChar?

I would argue heavily that the Zip file entry header should be platform agnostic ... otherwise you would need to supply different Zip-files for each platform. And since it works on one platform then I assume that it would also work on the others.

cmelchior

💯

re-writing accessors transformer using the new AGP API

e2419af

cla-bot bot added the cla: yes label Jun 30, 2022

cleanup

fbb9f08

nhachicha requested review from cmelchior and rorbech June 30, 2022 16:37

nhachicha linked an issue Jun 30, 2022 that may be closed by this pull request

RealmTransformer not executing on with AGP 7.2.0/1 #7685

Closed

nhachicha added 3 commits July 10, 2022 16:20

Using Java 11

8a3c558

Silencing Javadoc

a9a2575

Project already evaluated

15a02d5

iamkingalvarado reviewed Jul 22, 2022

View reviewed changes

WIP

207e5bc

cmelchior mentioned this pull request Aug 4, 2022

RealmTransformer not executing on with AGP 7.2.0/1 #7685

Closed

rorbech and others added 12 commits August 10, 2022 13:22

Fix sdk tests and all examples

bf97b43

Fix kotlin-extension tests

13a9de5

Fix example projects according to latest updates

e1aeed2

Merge branch 'master' into nh/new_transformer

8ad69c6

Revert annotations JDK target update

134a9bd

Fix processor test encoding issues

df23338

Ensure JNI headers are generated before native build

33081ef

Fix automatic dependency setup

3d780c8

Update to Core 12.5.1 and tests for raw queries with keyword field na…

f8940ce

…mes (#7711)

Strip object server symbols from base artifacts

1af01b7

Clean up

58a791e

Merge branch 'master' into nh/new_transformer

d895320

rorbech changed the base branch from master to feature/new-agp-transformer-api August 30, 2022 12:22

Update version

8f17c24

rorbech marked this pull request as ready for review August 31, 2022 08:49

Add CHANGELOG entry

eae54a1

geragray and others added 8 commits September 6, 2022 20:55

Update config.yml

98c6bbe

Update config.yml

77225f1

Update config.yml

a4f034b

Merge pull request #7718 from realm/geragray-patch-1

535bfb2

Update config.yml

Bump core 1.6.0 (#7717)

143fe75

Merge branch 'releases'

d7f3fda

Remove export compliance clause

64a7000

Merge pull request #7721 from realm/kn/clean-license

ba633a7

Remove export compliance clause

cmelchior approved these changes Sep 9, 2022

View reviewed changes

Christian Melchior and others added 3 commits September 13, 2022 15:00

Refactor EmailPasswordAuth tests to be less flaky. (#7723)

b057cab

Updates according to review comments

0357c11

Merge branch 'master' into nh/new_transformer

f7cde57

rorbech requested a review from cmelchior September 15, 2022 13:46

cmelchior approved these changes Sep 16, 2022

View reviewed changes

rorbech merged commit a53c4b6 into feature/new-agp-transformer-api Sep 16, 2022

rorbech deleted the nh/new_transformer branch September 16, 2022 09:36

TylerMcCraw mentioned this pull request Sep 22, 2022

Migrate to new transformer API #7714

Closed

github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024

Conversation

nhachicha commented Jun 30, 2022 • edited by rorbech Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nhachicha commented Jul 27, 2022

Uh oh!

rorbech commented Aug 31, 2022

Uh oh!

cmelchior left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rorbech Sep 15, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmelchior left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

nhachicha commented Jun 30, 2022 •

edited by rorbech

Loading

rorbech Sep 15, 2022 •

edited

Loading