-
Notifications
You must be signed in to change notification settings - Fork 111
chore: rm dist in files #379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
概览从 package.json 的 "files" 数组中移除了 "dist" 条目。此变更影响包发布时的文件包含范围,但不涉及逻辑或运行时行为的改变。 变更
代码审查工作量评估🎯 1 (微不足道) | ⏱️ ~2 分钟 诗歌
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
Tip 📝 Customizable high-level summaries are now available in beta!You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.
Example instruction:
Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @zombieJ, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the package distribution configuration by explicitly excluding the 'dist' directory from the list of files included in the published package. This adjustment helps to ensure that only essential build artifacts are distributed, potentially leading to a more streamlined and smaller package size. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 99 99
Branches 38 37 -1
=========================================
Hits 99 99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes the dist directory from the files array in package.json. This change correctly aligns the package manifest with the build output, as the dist directory is no longer being generated. This resolves the linked issue by making it official that a UMD build is no longer provided. While the change itself is correct, the removal of the dist folder and the corresponding UMD build could be considered a breaking change for users who were consuming it directly (e.g., via a CDN). It would be beneficial to clearly document this change in the release notes to ensure users are aware of this deprecation.
resolve ant-design/ant-design#55859
Summary by CodeRabbit
发布说明
✏️ Tip: You can customize this high-level summary in your review settings.