Skip to content

refactor(subscription): externalize status values to application.properties#256

Open
iRahmanG wants to merge 2 commits into
rdodiya:gssoc_developfrom
iRahmanG:fix/subscription-status-dynamic
Open

refactor(subscription): externalize status values to application.properties#256
iRahmanG wants to merge 2 commits into
rdodiya:gssoc_developfrom
iRahmanG:fix/subscription-status-dynamic

Conversation

@iRahmanG

Copy link
Copy Markdown
Contributor

This PR addresses the issue of hardcoded subscription status values in SubscriptionServiceImpl.

  • Removed hardcoded "ACTIVE" and "CANCELLED" strings in SubscriptionServiceImpl
  • Added subscription status values in application.properties files
  • Injected values using @value for dynamic loading
  • Ensures easier maintenance and consistent status management across environments
  • Implemented as per @rdodiya advice to avoid hardcoding enums and keep statuses flexible

By externalizing these values, future status changes can be managed through configuration without requiring code modifications.

Close Issue #235

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant