Support vector<bool> when loading and saving json#1521
Merged
yoshikikanemoto merged 3 commits intoproductionfrom Nov 19, 2025
Merged
Support vector<bool> when loading and saving json#1521yoshikikanemoto merged 3 commits intoproductionfrom
yoshikikanemoto merged 3 commits intoproductionfrom
Conversation
rdiankov
reviewed
Aug 21, 2025
| } | ||
| } | ||
|
|
||
| inline void LoadJsonValue(const rapidjson::Value& v, std::vector<bool>::reference t) |
Owner
There was a problem hiding this comment.
what is std::vector<bool>::reference? is that std::vector<bool>&?
Collaborator
There was a problem hiding this comment.
According to https://en.cppreference.com/w/cpp/container/vector_bool.html , vector<bool>& is not applicable
…o boolVectorJson_20250627
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.