Use new constraints type from DFG - #517
Open
KyleFromNVIDIA wants to merge 1 commit into
Open
Conversation
As of rapids-dependency-file-generator v1.22.0, a new output type, `constraints`, is supported, allowing constraints to be separated from requirements. Use this where possible. For now, be overzealous in turning on `constraints` wherever `requirements` is used. If we ever run into issues with constraints having extras, we can deal with it at that time. Contributes to rapidsai/build-planning#311
Contributor
Greptile SummaryThe PR adopts DFG v1.22.0's dedicated constraints output for wheel CI.
Confidence Score: 5/5The PR appears safe to merge with no substantive changed-code defect identified. The generator upgrade, dependency metadata, and CI consumers are updated coherently to use the new constraints output while preserving the existing package pins and pip index options. Important Files Changed
Reviews (1): Last reviewed commit: "Use new `constraints` type from DFG" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of rapids-dependency-file-generator v1.22.0, a new output type,
constraints, is supported, allowing constraints to be separated from requirements. Use this where possible.For now, be overzealous in turning on
constraintswhereverrequirementsis used. If we ever run into issues with constraints having extras, we can deal with it at that time.Contributes to rapidsai/build-planning#311