Add opt-in RMM allocation for WholeMemory - #505
Open
alexbarghi-nv wants to merge 11 commits into
Open
Conversation
Member
Author
|
/ok to test 64ea3f3 |
bdice
reviewed
Jul 23, 2026
alexbarghi-nv
force-pushed
the
agent/enable-rmm-wholememory-allocation
branch
from
July 27, 2026 18:34
83c09bc to
23bb681
Compare
alexbarghi-nv
marked this pull request as ready for review
July 27, 2026 18:35
Member
Author
|
/ok to test 23bb681 |
Contributor
Greptile SummaryAdds opt-in RMM allocation support for WholeMemory.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (8): Last reviewed commit: "Merge branch 'main' into agent/enable-rm..." | Re-trigger Greptile |
alexbarghi-nv
marked this pull request as draft
July 27, 2026 19:26
alexbarghi-nv
marked this pull request as ready for review
July 27, 2026 19:33
Member
Author
|
/ok to test da656ce |
Member
Author
|
/ok to test 0004b48 |
tingyu66
approved these changes
Jul 27, 2026
bdice
requested changes
Jul 27, 2026
bdice
left a comment
Contributor
There was a problem hiding this comment.
One CMake issue needs to be fixed before we can merge.
|
|
||
| include(./cmake/thirdparty/get_raft.cmake) | ||
| include(./cmake/thirdparty/get_nccl.cmake) | ||
| find_package(rmm "${RAPIDS_VERSION}" REQUIRED) |
Contributor
There was a problem hiding this comment.
Please copy https://github.com/rapidsai/cudf/blob/main/cpp/cmake/thirdparty/get_rmm.cmake, don't use plain find_package here. This must go before get_raft.cmake so that RMM is found by wholegraph (potentially with custom branches/etc.) before RAFT attempts to find RMM.
Member
Author
|
/ok to test 217ff8a |
linhu-nv
reviewed
Jul 28, 2026
…hub.com/rapidsai/cugraph-gnn into agent/enable-rmm-wholememory-allocation
Member
Author
|
/ok to test 5c9ee13 |
Member
Author
|
/ok to test 08f3ba7 |
jameslamb
removed their request for review
August 7, 2026 02:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pylibwholegraph.torch.set_memory_resource()/is_rmm_enabled()to opt supported WholeMemory allocations into RMMcuda::device_buffer<cuda::std::byte>, explicitly backed by RMM's current per-device resourceTest coverage
None, rejects invalid resource types, and reports finalization state correctlyLocal testing
Tested locally in the
rapidsconda environment with CUDA 12.9, GCC 14, RMM 26.10, CCCL 3.4, and NVIDIA V100 GPUs:WHOLEMEMORY_HANDLE_TEST(passed)WHOLEMEMORY_HANDLE_TESTon two peer-connected V100s: 20 tests passedWholeMemoryHandleRMMTests.*two-GPU run (passed)git diff --check(passed)