chore: revert Event Logger integration but keep API retry improvements (RMCCX-10248)#406
Merged
maureenorea-clores merged 1 commit intoFeb 4, 2026
Conversation
|
Collaborator
JaCoCo Code Coverage 97.09% ✅
Generated by 🚫 Danger |
maureenorea-clores
requested review from
leila-gu and
mdusmangani-jp
as code owners
puneetksh
reviewed
Feb 3, 2026
| response.isSuccessful -> response.body() | ||
| response.code() >= HttpURLConnection.HTTP_INTERNAL_ERROR -> checkAndRetry(callClone) { | ||
| logFailedResponse(response) | ||
| WorkerUtils.logRequestError(DISP_TAG, response.code(), response.errorBody()?.string()) |
Contributor
There was a problem hiding this comment.
What is the objective of WorkerUtils.logRequestError(...)?
how this differs from InAppLogger(TAG).error(...)
Collaborator
Author
There was a problem hiding this comment.
logRequestError logs in the console and return the error to client
puneetksh
approved these changes
Feb 3, 2026
puneetksh
left a comment
puneetksh
left a comment
Contributor
There was a problem hiding this comment.
Just one question, I have asked on this PR, else, the changes in this PR are looking good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reverted 1bdfb9e but kept API retry improvements
Links
N/A
Checklist
./gradlew checkwithout errors