Open
Conversation
Collaborator
|
@dmeijboom thanks for this! At a first glance, this look great. Will take a look next week and get it merged. |
dmeijboom
force-pushed
the
feat/support-nextjs-spas
branch
from
73ee308 to
5e25cc7
Compare
Author
Nice! Appreciate it. Updated the PR to fix failing linting/tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for NextJS SPAs (when using
output: "export"to export static HTML). It supports the default output directory as well as a custom output directory (similar to Astro).Changes
ReadFirstFileOf(..)to read the first existing file from a slice of filenamesReadFirstFileOf(..)(where applicable)next.gofor NextJS SPA related code which closely mirrorsastro.goTesting
Added a new test to verify next SPAs and tested manually with an existing project, both with
outputas"export"(SPA) as well as"standalone"(not SPA).