Pin connection_pool to ~> 2.5 to fix boot failure#217
Merged
Conversation
0481814 to
50f4e85
Compare
connection_pool 3.0.2 dropped the positional hash argument from ConnectionPool#initialize. activesupport 8.0.3 still passes it positionally, causing a boot failure on asset precompile. Pin to ~> 2.5 until activesupport is updated to use keyword args.
50f4e85 to
60e8a4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Deploy failed during `rake assets:precompile`:
```
ArgumentError: wrong number of arguments (given 1, expected 0)
connection_pool-3.0.2 ConnectionPool#initialize
```
`connection_pool 3.0.2` changed `initialize` to keyword-only arguments, removing the positional hash form. `activesupport 8.0.3` still calls `ConnectionPool.new(pool_options)` with a positional hash, which breaks on boot.
This was introduced by `bundle update sentry-ruby sentry-rails sentry-sidekiq` which transitively bumped `connection_pool` from `2.5.4` to `3.0.2`.
Fix
Re-ran `bundle update sentry-ruby sentry-rails sentry-sidekiq --conservative` to keep `connection_pool` at `2.5.5` (closest to original `2.5.4`) without adding an explicit Gemfile entry. The lockfile constraint is sufficient — no direct dependency needed.
Boot verified locally. `Gemfile.next.lock` was already at `2.5.4` and required no changes.
Note: `connection_pool 3.0.2` release notes mention a backwards-compat fix for `:name` keyword (issue #210) but that is unrelated — the breaking change is the broader positional→keyword-only `initialize` API change introduced in 3.0.