Skip to content

Pin connection_pool to ~> 2.5 to fix boot failure#217

Merged
JuanVqz merged 1 commit intomainfrom
fix/pin-connection-pool
May 6, 2026
Merged

Pin connection_pool to ~> 2.5 to fix boot failure#217
JuanVqz merged 1 commit intomainfrom
fix/pin-connection-pool

Conversation

@JuanVqz
Copy link
Copy Markdown
Member

@JuanVqz JuanVqz commented May 6, 2026

Problem

Deploy failed during `rake assets:precompile`:

```
ArgumentError: wrong number of arguments (given 1, expected 0)
connection_pool-3.0.2 ConnectionPool#initialize
```

`connection_pool 3.0.2` changed `initialize` to keyword-only arguments, removing the positional hash form. `activesupport 8.0.3` still calls `ConnectionPool.new(pool_options)` with a positional hash, which breaks on boot.

This was introduced by `bundle update sentry-ruby sentry-rails sentry-sidekiq` which transitively bumped `connection_pool` from `2.5.4` to `3.0.2`.

Fix

Re-ran `bundle update sentry-ruby sentry-rails sentry-sidekiq --conservative` to keep `connection_pool` at `2.5.5` (closest to original `2.5.4`) without adding an explicit Gemfile entry. The lockfile constraint is sufficient — no direct dependency needed.

Boot verified locally. `Gemfile.next.lock` was already at `2.5.4` and required no changes.

Note: `connection_pool 3.0.2` release notes mention a backwards-compat fix for `:name` keyword (issue #210) but that is unrelated — the breaking change is the broader positional→keyword-only `initialize` API change introduced in 3.0.

@JuanVqz JuanVqz self-assigned this May 6, 2026
@JuanVqz JuanVqz force-pushed the fix/pin-connection-pool branch from 0481814 to 50f4e85 Compare May 6, 2026 17:44
connection_pool 3.0.2 dropped the positional hash argument from
ConnectionPool#initialize. activesupport 8.0.3 still passes it
positionally, causing a boot failure on asset precompile.

Pin to ~> 2.5 until activesupport is updated to use keyword args.
@JuanVqz JuanVqz force-pushed the fix/pin-connection-pool branch from 50f4e85 to 60e8a4e Compare May 6, 2026 17:47
@JuanVqz JuanVqz merged commit ded3739 into main May 6, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant