[mgt] Remove LOGIN_SESSION_TIMEOUT from the m Cookie (backport #16894)#16929
Merged
Conversation
Author
|
Tick the box to add this pull request to the merge queue (same as
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Remove unnecessary pseudo-cookie (entry stored within the m cookie) .
This change is part of an effort of securing cookies. All cookies that exists in the management ui are now owned by the server and fully secured with the right attributes. The only cookie left is m, controlled by the client side, which only exists for the pseudo-cookie LOGGED_IN which has a TTL that controls the lifespan of the client-side session. This cookie has no value hence it is fine that it is not fully secured because javascript created cookies cannot be fully secured.
Also, this pseudo-cookie needs to be accessed by javascript hence it cannot be owned by the server.
Types of Changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyThis is an automatic backport of pull request #16894 done by [Mergify](https://mergify.com).