-
Notifications
You must be signed in to change notification settings - Fork 299
Fix st_cast empty geometry split ordering #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
FYI this was all gpt-5.1-codex-max-xhigh (including the PR) |
|
That's a lot of code. Could you provide a very small example of what this code tries to solve? |
|
Testing should also include full reverse dependency checks of all reverse depencencies, with comparative timings and memory profiling. |
|
Sorry I missed the reference to the issue which contains the small example of what this code tries to solve #2555 |
Running this now with r-lib/revdepcheck |
|
Did the |
It did but it didn't manage to check everything. The new problems are also new problems on main (vs CRAN). Do you consider this a pass? I haven't done memory profiling or comparative timings yet, but wouldn't a more targeted performance test (testing only cast) be better? |
Summary
Testing