chore: add macos to tesing #1741
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crozzy
force-pushed
the
try-add-macos-to-matrix
branch
4 times, most recently
from
52eeadb to
a936491
Compare
Contributor
Author
|
@BradLugo could you possibly check this branch locally? |
Member
|
These changes don't work because |
Contributor
|
In other words, the seeks/reads/writes are not independent. Hank and I discussed this solution on Slack before, and he showed me the light: https://www.man7.org/linux/man-pages/man2/open.2.html#:~:text=Open%20file%20descriptions,-The |
crozzy
force-pushed
the
try-add-macos-to-matrix
branch
from
a936491 to
b0fb426
Compare
This change adds another job to the CI which can will test on platforms other than ubuntu-latest. At the moment it's only testing macos-latest with the fetcher tests but can be expanded in either direction. Signed-off-by: crozzy <[email protected]>
When forcing the linux fallback (no O_TMPFILE) it triggers an error: encountered errors: openat fetcher.xxxxxxxx: no such file or directory, when adding the O_CREATE flag the fallback's error was fixed. This also adds the flags to the unix and windows variants. Signed-off-by: crozzy <[email protected]>
crozzy
force-pushed
the
try-add-macos-to-matrix
branch
from
b0fb426 to
007bdb1
Compare
f.Name() returns the full absolute path, but os.Root.OpenFile()expects a path relative to the root. Use Base() to get just the filename. Signed-off-by: crozzy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: this is a test