ncm-freeipa: add realm to the principal, get rid of error messages on freeipa servers#1870
Open
kwaegema wants to merge 1 commit into
Open
ncm-freeipa: add realm to the principal, get rid of error messages on freeipa servers#1870kwaegema wants to merge 1 commit into
kwaegema wants to merge 1 commit into
Conversation
stdweird
reviewed
May 11, 2026
stdweird
reviewed
May 11, 2026
stdweird
reviewed
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-we seem to be running freeipa/aii server with a line commented out for a long time.
I added some logic that does the same, only for those roles.
this effectively removes the error we get on the servers, but
I'm not completely sure what the impact of his is, @stdweird could you shine your light on this, is it safe to remove this context check for the servers?