perf: collapse operator-product specialization to cut TTFX#172
Draft
oameye wants to merge 1 commit into
Draft
Conversation
@nospecialize/@nospecializeinfer on the three * operator-product methods
(*(QSym,QSym), *(QAdd,QSym), *(QSym,QAdd)) collapses their per-operator-pair
codegen specializations; the bodies only box into Vector{QSym} so the concrete
operator type is irrelevant. Function-barrier return-type assertions in the
canonicalization passes stop the abstract-Vector{QSym} Any-cascade (report_opt
15->5 runtime-dispatch sites). Measured ~1.7s (~10%) first-call reduction on the
JC meanfield+complete workload; results and runtime unchanged.
Adds benchmark/TTFX_REPORT.md documenting the full investigation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 23 23
Lines 2157 2157
=======================================
Hits 2038 2038
Misses 119 119 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.