[feat] add TTL for grandpa historical votes and update storage spaces#2467
Open
kamilsa wants to merge 2 commits into
Open
[feat] add TTL for grandpa historical votes and update storage spaces#2467kamilsa wants to merge 2 commits into
kamilsa wants to merge 2 commits into
Conversation
turuslan
approved these changes
Jun 12, 2025
xDimon
approved these changes
Jun 14, 2025
Member
xDimon
left a comment
There was a problem hiding this comment.
How about to use in-memory storage for such data?
|
|
||
| inline auto historicalVotesKey(AuthoritySetId set, RoundNumber round) { | ||
| auto key = storage::kGrandpaHistoricalVotesPrefix; | ||
| common::Buffer key; |
Member
There was a problem hiding this comment.
Remove unused anymore key storage::kGrandpaHistoricalVotesPrefix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Referenced issues
Closes #2468
Description of the Change
We have noticed that historical votes contribute the most to the grow of the database.
The problem was that KAGOME didn't have pruning mechanism for historical votes.
To solve that problem this PR:
Note, that in reality historical votes won't be cleared every two minutes, but rather their database entries will be marked as expired. The real removal of expired historical votes database entries will happen during database compaction, which happens automatically once in a while
Possible Drawbacks
None
Checklist Before Opening a PR
Before you open a Pull Request (PR), please make sure you've completed the following steps and confirm by answering 'Yes' to each item: