Simplify building - #28
Conversation
|
If it has been working for several years and it is expected to continue working in the coming years, is there a reason to change it? |
|
reducing complexity and dependencies is almost always a good thing. less possibilities of things breaking (for example: cmake api changes) over time |
|
Would this PR work out of the box or require other changes to support the automatic release process? I’m hesitant to merge it as I’ve yet to become more familiar with these newer tools, and the current process works (despite its bulkiness). |
|
I'm not 100% sure on the CI process. I was just following the example from the pybind11 docs: https://github.com/pybind/python_example I'm 90% sure CI will need some tweaking to get working smoothly, but I have not published my own packages so I don't want to make changes for it in case I break it |
|
@pzelasko I tested the new CI using pypi test index. it works. |
|
That is great @sakgoyal! @pzelasko, would you consider merging this? I built basnijholt/agent-cli#436 which pulls in kaldialign via NeMo. The annoying bit is that with newer Python versions there are no wheels and the library becomes very hard to install. |
|
For which platform / python the wheels are missing? I’ll think about it, fell off my radar. Maybe. |
|
Small correction: I realized the remaining blocker for my downstream case is now mostly on the NeMo side.
I opened this NeMo PR to relax the cap: NVIDIA-NeMo/Speech#15438 It is merged on NeMo I just posted about this here too NVIDIA-NeMo/Speech#15438 (comment) |
|
There will be a new NeMo release soon, we’ve reorganized NeMo repos and needed more time to get everything in order. Sorry for the trouble. |
|
I have rebased this with the latest changes |
|
Thanks!
Actually wheel gaps I’m seeing on PyPI:
So for the NeMo case, relaxing the cap to allow Another source of confusion: GitHub Releases currently only goes up to
Any idea how soon? For now I am relying on the worlds ugliest hacks 😭 |
|
rebased again. any updates on if this will get merged? |
Co-authored-by: Cursor <cursoragent@cursor.com>
Related to #27
pybind11directly with setuptools._kaldialign.pyifile so LSPs can see the extension types