Fix bad return of hashes#392
Fix bad return of hashes#392bhearsum wants to merge 1 commit intopyupio:masterfrom bhearsum:fix-hash-return
Conversation
Codecov Report
@@ Coverage Diff @@
## master #392 +/- ##
=======================================
Coverage 94.20% 94.20%
=======================================
Files 11 11
Lines 1157 1157
=======================================
Hits 1090 1090
Misses 67 67
Continue to review full report at Codecov.
|
rafaelpivato
left a comment
There was a problem hiding this comment.
You are totally right! The PyPi Warehouse JSON API return no hashes field and the function is clearly trying to return a list of hashes. I am wondering what other impacts with have with this.
Do you think you would be able to add a unit test for this? Maybe you mock some PyPi Warehouse API result and check its results. If you can do that, it would be great to avoid regressions.
Avoiding regression is great, but in the meantime, the tool is broken. Please consider merging this as-is |
I might be missing something, but I'm not sure how the code is supposed to work in its current form - when I use debug logging,
dataquite clearly does not containhashes, and the block above this pretty clear is meant to built up the hashes that the caller wants.