-
Notifications
You must be signed in to change notification settings - Fork 427
[Feature] Add support for trackio
#3196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/3196
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New Failures, 12 Pending, 1 Unrelated FailureAs of commit 4df79b6 with merge base 2644b89 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
vmoens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting this up!
- We need to add it to the doc (docs/source/reference)
- We need to consider if trackio should be installed as part of the dependencies of the main linux tests
Other than that happy to go ahead
|
Added the docs and |
vmoens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool happy with these changes!
9f095e0 to
08787c3
Compare
Description
Add support for
trackio, for now I have a small trouble with the video save folder (cf gradio-app/trackio#307), but the logging works.Edit: gradio-app/trackio#307 was solved.
Motivation and Context
Fix #3195
Types of changes
What types of changes does your code introduce? Remove all that do not apply:
Checklist
Go over all the following points, and put an
xin all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!