Skip to content

Conversation

@YufengShi-dudu
Copy link
Collaborator

@YufengShi-dudu YufengShi-dudu commented Dec 22, 2025

  • Add RewriteBoolToFp32CastViaInt8Pass to rewrite unsupported bool->fp32 to_dim_order_copy into bool->int8->fp32 when both INT and FP TOSA profiles are enabled
  • Extend to_dim_order_copy operator support to include bool->fp32 for the INT+FP profile

Change-Id: I38a51557480e87b4590acff47cbd8c487b3fa7d2

cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai

- Add RewriteBoolToFp32CastViaInt8Pass to rewrite unsupported
  bool->fp32 to_dim_order_copy into bool->int8->fp32 when both INT
  and FP TOSA profiles are enabled
- Extend to_dim_order_copy operator support to include bool->fp32
  for the INT+FP profile

Change-Id: I38a51557480e87b4590acff47cbd8c487b3fa7d2
Signed-off-by: Yufeng Shi <[email protected]>
@YufengShi-dudu YufengShi-dudu added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk release notes: arm Changes to the ARM backend delegate labels Dec 22, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 22, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16363

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Unrelated Failure

As of commit f18559b with merge base 0ee2f49 (image):

NEW FAILURE - The following job has failed:

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 22, 2025
@zingo
Copy link
Collaborator

zingo commented Dec 23, 2025

Seem to have 3 tests files in a cortex-m job
FAILED backends/arm/test/ops/test_activation.py::test_dialect_activation[conv2d_hardsigmoid_inplace]
(and 2 more)
I retriggred the job to make sure it's not something flakey, lets see it it's still an error after retesting.

@YufengShi-dudu
Copy link
Collaborator Author

Hey Zingo, it seems to start failing from this PR: #16233
trunk: https://github.com/pytorch/executorch/actions/runs/20438840159/job/58726771546

@zingo
Copy link
Collaborator

zingo commented Dec 23, 2025

@zingo zingo merged commit 39203cf into pytorch:main Dec 23, 2025
436 of 439 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm release notes: arm Changes to the ARM backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants