Clean up various leftover platform arg usage around the repo that never hit validation #16299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16299
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit ea20160 with merge base 257da59 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
Author
|
@pytorchbot label "release notes: none" |
pytorch-bot
bot
added
the
release notes: none
…er hit validation (pytorch#16299) Summary: Cleaning up platform args before the whole feature gets deleted. These missed our validation. --- These are to force android builds of mwa for xplat diffs Reviewed By: mzlee Differential Revision: D89322661
8Keep
force-pushed
the
export-D89322661
branch
from
4dc3320 to
ea20160
Compare
GregoryComer
approved these changes
Dec 17, 2025
Member
GregoryComer
left a comment
GregoryComer
left a comment
There was a problem hiding this comment.
Looks good to me. I'm not an expert on buck, but as long as OSS CI is green, we should be good. You will need to ensure that the internal diff is in sync with the PR, which can be a pain with internal-only changes.
meta-codesync bot
pushed a commit
to facebook/ocamlrep
that referenced
this pull request
Dec 17, 2025
…er hit validation Summary: X-link: pytorch/executorch#16299 Cleaning up platform args before the whole feature gets deleted. These missed our validation. --- These are to force android builds of mwa for xplat diffs Reviewed By: mzlee, GregoryComer Differential Revision: D89322661 fbshipit-source-id: d777f02d86b9118f300c92a572755f97e6811400
meta-codesync bot
pushed a commit
to facebook/buck2
that referenced
this pull request
Dec 17, 2025
…er hit validation Summary: X-link: pytorch/executorch#16299 Cleaning up platform args before the whole feature gets deleted. These missed our validation. --- These are to force android builds of mwa for xplat diffs Reviewed By: mzlee, GregoryComer Differential Revision: D89322661 fbshipit-source-id: d777f02d86b9118f300c92a572755f97e6811400
meta-codesync bot
pushed a commit
to facebook/buck2-shims-meta
that referenced
this pull request
Dec 17, 2025
…er hit validation Summary: X-link: pytorch/executorch#16299 Cleaning up platform args before the whole feature gets deleted. These missed our validation. --- These are to force android builds of mwa for xplat diffs Reviewed By: mzlee, GregoryComer Differential Revision: D89322661 fbshipit-source-id: d777f02d86b9118f300c92a572755f97e6811400
xingguo01
pushed a commit
to xingguo01/executorch
that referenced
this pull request
Dec 18, 2025
…er hit validation Differential Revision: D89322661 Pull Request resolved: pytorch#16299
jirioc
pushed a commit
to nxp-upstream/executorch
that referenced
this pull request
Dec 19, 2025
…er hit validation Differential Revision: D89322661 Pull Request resolved: pytorch#16299
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Cleaning up platform args before the whole feature gets deleted. These missed our validation.
These are to force android builds of mwa for xplat diffs
Reviewed By: mzlee
Differential Revision: D89322661