-
-
Notifications
You must be signed in to change notification settings - Fork 33.9k
gh-141004: Don't trigger run-tests when Tools/check-c-api-docs/ignored_c_api.txt is changed
#143583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@hugovk maybe you could please take a look? |
ZeroIntensity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'm fine with this. Since it's right before the weekend, I'll give others a few more days to take a look before merging.
| Path(".github/CODEOWNERS"), | ||
| Path(".pre-commit-config.yaml"), | ||
| Path(".ruff.toml"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth keeping CONFIGURATION_FILE_NAMES and just flattening it here, but I'm not going to block the PR on it.
|
Idle thought, we could write: if not (doc_file or file in RUN_TESTS_IGNORE):As: if not doc_file and file not in RUN_TESTS_IGNORE:I think that's a little clearer? An unrelated condition that could be made clearer in this file is: if not has_platform_specific_change or not platforms_changed:
a
else:
bIs the same as: if not (has_platform_specific_change and platforms_changed):
a
else:
bAnd flip to put the positive first: if has_platform_specific_change and platforms_changed:
b
else:
a |
Uh oh!
There was an error while loading. Please reload this page.