Skip to content

Conversation

@itamaro
Copy link
Contributor

@itamaro itamaro commented Nov 24, 2024

No description provided.

@itamaro
Copy link
Contributor Author

itamaro commented Nov 24, 2024

@zware @mdboom if there are no concerns with the implementation, I will merge this tomorrow, when I can keep an eye on the Windows worker more closely.

@db3l
Copy link

db3l commented Nov 25, 2024

@itamaro, if you could, when you enable this tomorrow, could you specifically take a peek at how test_cext does?

It looks like it's been failing on my new PGO builder. I haven't had a lot of time to look into it, but from what I can tell it didn't run in the past as it skips debug mode on Windows - but the PGO builder is no longer debug mode. I didn't notice this during my manual test as I hadn't enabled the "cpu" resource so it didn't even try test_cext.

What I'm not sure is whether test_cext should be modified to skip any Windows build, or just PGO, or if it ought to work in release/pgo mode and the PGO builder is just highlighting something on my worker.

Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@itamaro itamaro merged commit d6a78bb into python:main Nov 25, 2024
1 check passed
@itamaro
Copy link
Contributor Author

itamaro commented Nov 25, 2024

@db3l test_cext passed, but 5 other tests failed (test_call test_class test_functools test_int test_ssl)

logs: https://buildbot.python.org/#/builders/1622/builds/1/steps/5/logs/stdio

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants