fix: implement startup armouring and update 3.x docs #2877
Closed
+29
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FedericoMusa
force-pushed
the
fix/simulator-armouring-and-3x-docs
branch
from
9d52575 to
5bb6639
Compare
janiversen
requested changes
Feb 11, 2026
| if not os.path.exists(args.json_file): | ||
| # Configuramos un log básico para asegurar que el error fatal sea visible | ||
| pymodbus_apply_logging_config("ERROR") | ||
| Log.error(f"FATAL: Configuration file '{args.json_file}' not found.") |
Collaborator
There was a problem hiding this comment.
Please make that one log call, instead of 3,since it is only 1 error.
| sys.exit(1) | ||
| return cmd_args | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
General coding style is 2 empty lines between methods.
Contributor
Author
There was a problem hiding this comment.
Jan, closing this PR in favor of #2877 to avoid duplication. I have consolidated all recent style and logic fixes in the other branch. Sorry for the confusion!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Jan! I've implemented the simulator startup 'armouring' and updated the documentation following the 3.x path.
Fail-Fast Logic: The simulator now checks for --json_file existence and exits with a FATAL error if missing.*
3.x Docs: Detailed the command line parameters in doc/source/library/simulator/config.rst.*
CI Ready: Verified that imports are top-level and compliant with Pylint.*
Ready for merge!