feat(tools/intro-video): record dashboard in presentation mode (clean frames)#497
Merged
Merged
Conversation
…lean frames) Follows up REQ-207 (#482, presentation/clean mode for serve): the intro-video capture now appends `?presentation=1` to the four dashboard scene URLs (open_dashboard, browse_artifacts, open_artifact, show_coverage), so the recorded video hides the working-state chrome (branch / "N uncommitted" / path / Reload+Print) and shows a clean dashboard regardless of the recording machine's git state. The title/CLI-help/outro scenes use setContent and are unaffected. This closes the loop on the chrome that was visible in every frame of the first intro-video capture. Verified by composition: presentation mode is proven (presentation-mode.spec.ts, 4 passing) and these URLs now use it. Refs: REQ-207
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: ccd5880 | Previous: b7f44a1 | Ratio |
|---|---|---|---|
store_lookup/1000 |
24853 ns/iter (± 132) |
19427 ns/iter (± 133) |
1.28 |
validate/10000 |
1462678889 ns/iter (± 21092749) |
959579767 ns/iter (± 5731186) |
1.52 |
diff/1000 |
725911 ns/iter (± 3050) |
584381 ns/iter (± 5875) |
1.24 |
query/1000 |
14750 ns/iter (± 271) |
11588 ns/iter (± 18) |
1.27 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to REQ-207 / #482 (serve presentation mode). The intro-video capture now appends
?presentation=1to the four dashboard scene URLs, so the recorded video hides the branch / "N uncommitted" / path / Reload+Print chrome — the exact thing that was visible in every frame of the firstrivet-intro.mp4.gotoscenes (open_dashboard, browse_artifacts, open_artifact, show_coverage); title/CLI-help/outro usesetContentand are unchanged.tools/only (not in CI; the capture produces an artifact, not assertions).presentation-mode.spec.ts, 4 passing); confirming the live capture produces clean frames as part of landing.Next: a full re-record (
generate.sh) produces a clean narratedrivet-intro.mp4ready for YouTube.🤖 Generated with Claude Code