feat(serve): presentation/clean mode for recordings (REQ-207, closes #482)#492
Merged
Conversation
…ecordings (REQ-207, closes #482) #482: the serve dashboard context bar always shows branch@sha, an "N uncommitted" badge, the absolute project path, and Reload/Print buttons — which leaked into every frame of the intro-video capture (unprofessional, and exposes in-progress branch names / machine paths in published media). Adds `?presentation=1` (alias `?clean=1`): an inline <head> script sets a `presentation` class on the document root, and CSS hides `.context-bar` while it's set. Client-side and set once on load, so it survives HTMX swaps (which only replace #content) — the capture spec / a user just appends the param. Default (no param) is unchanged; no server plumbing. Test (presentation-mode.spec.ts): context bar visible normally, hidden with ?presentation=1 and ?clean=1, and the class survives an HTMX navigation. Dataset-independent (the bar renders on every page regardless of corpus size). Confirmed with: cargo build -p rivet-cli; curl /artifacts?presentation=1 shows the toggle + CSS rule; npx playwright test presentation-mode.spec.ts (4 passed); cargo fmt --check + clippy --all-targets -- -D warnings (exit 0); rivet validate PASS. Implements: REQ-207 Verifies: REQ-207 Refs: FEAT-001
📐 Rivet artifact delta
Graphgraph LR
REQ_207["REQ-207"]:::added
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Added
Posted by |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 9d7fe91 | Previous: 00b59a5 | Ratio |
|---|---|---|---|
store_lookup/100 |
2145 ns/iter (± 37) |
1717 ns/iter (± 3) |
1.25 |
store_lookup/1000 |
26404 ns/iter (± 158) |
19422 ns/iter (± 556) |
1.36 |
validate/10000 |
1399108185 ns/iter (± 18863477) |
966587939 ns/iter (± 5057977) |
1.45 |
traceability_matrix/1000 |
61054 ns/iter (± 1182) |
41476 ns/iter (± 3751) |
1.47 |
query/100 |
1159 ns/iter (± 6) |
893 ns/iter (± 5) |
1.30 |
query/1000 |
15155 ns/iter (± 133) |
11653 ns/iter (± 194) |
1.30 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #482. The
rivet servedashboard's context bar always shows branch@sha, an "N uncommitted" badge, the absolute project path, and Reload/Print buttons — which leaked into every frame of the intro-video capture (and would into any screenshot), looking unprofessional and exposing in-progress branch names / machine paths.Fix
?presentation=1(alias?clean=1) adds apresentationclass on the document root; CSS hides.context-barwhile set. Client-side, set once on load, so it survives HTMX navigations (which only swap#content) — the capture spec or a user just appends the param. Default (no param) unchanged; no server plumbing.Verification
curl /artifacts?presentation=1→ HTML carries the toggle script +.presentation .context-bar{display:none}rule.presentation-mode.spec.ts(4 tests, dataset-independent): bar visible normally; hidden with?presentation=1and?clean=1; class survives an HTMX nav. All pass locally.cargo fmt --check+clippy --all-targets -- -D warningsexit 0 ·rivet validatePASS.Implements + Verifies REQ-207. Useful immediately for re-recording the intro video without the branch/dirty chrome.
🤖 Generated with Claude Code