Skip to content
This repository was archived by the owner on Nov 3, 2022. It is now read-only.

Support iPhone12, 12 Pro, 12 Pro Max, 12 Mini, 13, 13 Pro, 13 Pro Max, 13 Mini, 14, 14 Plus, 14 Pro, 14 Pro Max - #45

Open
Norcy wants to merge 4 commits into
ptelad:masterfrom
Norcy:feat/iPhone14
Open

Support iPhone12, 12 Pro, 12 Pro Max, 12 Mini, 13, 13 Pro, 13 Pro Max, 13 Mini, 14, 14 Plus, 14 Pro, 14 Pro Max#45
Norcy wants to merge 4 commits into
ptelad:masterfrom
Norcy:feat/iPhone14

Conversation

@Norcy

@Norcy Norcy commented Sep 19, 2022

Copy link
Copy Markdown

Feat: Support All Devices except iPhone11 & iPhone Xr

StatusBarHeight Devices
20 Others
44 iPhoneX, Xs, Xs Max, 11 Pro, 11 Pro Max
47 iPhone12, 12 Pro, 12 Pro Max, 13, 13 Pro, 13 Pro Max, 14, 14 Plus
48(Not Supported Now) iPhone11, Xr
50 iPhone12 Mini, 13 Mini
59 iPhone14 Pro、14 Pro Max

Fix: Dimensions.get("window") 's width & height is not correct sometimes when Dimensions.get("srceen") is correct

Feat: remove getStatusBarHeight param safe,which is useless in actual use

@Norcy Norcy changed the title Feat/i phone14 Adapt iPhone14 and fix older device bug Sep 19, 2022
@Norcy Norcy changed the title Adapt iPhone14 and fix older device bug Support iPhone12, 12 Pro, 12 Pro Max, 12 Mini, 13, 13 Pro, 13 Pro Max, 13 Mini, 14, 14 Plus, 14 Pro、14 Pro Max Sep 19, 2022
@Norcy Norcy changed the title Support iPhone12, 12 Pro, 12 Pro Max, 12 Mini, 13, 13 Pro, 13 Pro Max, 13 Mini, 14, 14 Plus, 14 Pro、14 Pro Max Support iPhone12, 12 Pro, 12 Pro Max, 12 Mini, 13, 13 Pro, 13 Pro Max, 13 Mini, 14, 14 Plus, 14 Pro, 14 Pro Max Sep 19, 2022
@RZulfikri

Copy link
Copy Markdown

looks good. 👍🏼

@yamov

yamov commented Oct 10, 2022

Copy link
Copy Markdown

Thanks a lot for the fix. Any chance to have it released soon?

@Norcy

Norcy commented Oct 10, 2022

Copy link
Copy Markdown
Author

Thanks a lot for the fix. Any chance to have it released soon?

Any one can help merge❓

@Lisergishnu

Copy link
Copy Markdown

Looking forward for this merge 👍

@lucasferreira

Copy link
Copy Markdown

Waiting for merge this also ;)

@vlkpa

vlkpa commented Oct 17, 2022

Copy link
Copy Markdown

@ptelad ?

@YaroslavReact

Copy link
Copy Markdown

we're still waiting!)

@BrunnoGonzalezArbo

Copy link
Copy Markdown

Waiting for merge this also !!

@aryella-lacerda

Copy link
Copy Markdown

Waiting for merge as well!

@teivienn

teivienn commented Nov 2, 2022

Copy link
Copy Markdown

I guess this repository is dead🥲 but many community packages include it's has dependency (for example react-navigation). Maybe who known alternative or can to contact to author and get access to publish new version.

Also we can create organizations how like https://github.com/react-native-device-info/react-native-device-info and continue support. But I think it's deprecated cause we can use hasNotch method from device-info instead isIPhoneX.

@ptelad what do you think about it?

@ekoooo

ekoooo commented Nov 3, 2022

Copy link
Copy Markdown

Thank you, i use patch-package tool created patch to fix my issue.

@vlkpa

vlkpa commented Nov 3, 2022

Copy link
Copy Markdown

you can use fork = react-native-iphone-screen-helper

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.