fix(product): ask the brownfield question even in unattended runs#143
fix(product): ask the brownfield question even in unattended runs#143AlexanderMakarov wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated documentation in commands/product.md revises the Creation Mode brownfield decision logic. The silent prompt branch now always asks via AskUserQuestion with fixed labels when source code indicators are detected, defaulting to "Yes, explore the codebase" if left unanswered. ChangesProduct command documentation update
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…found The silent-prompt brownfield branch ended with "This question is reached only in an interactive run …; an unattended run states its choice in the prompt" — a model reads that as permission to skip the question and silently pick a default, so the explore/skip choice never reaches the user (observed consistently in awos-qa e2e runs). Since #141 the deliverable Write no longer waits on any answer, so asking is always safe: drop the sentence, make the ask unconditional, pin the exact option labels (models paraphrase otherwise), and give the unanswered case an explicit default (Yes, explore) consistent with the INTERACTION rule that an unanswered question is never a stop signal. Claude-Session: https://claude.ai/code/session_01D56dVJjUsoRYEUnxcx3zsH
9e824f5 to
d4fd7c4
Compare
The silent-prompt brownfield branch of
commands/product.mdended with "This question is reached only in an interactive run whose prompt expressed no preference; an unattended run states its choice in the prompt." In practice a model reads that as permission to skip the question and silently pick a default — observed consistently in awos-qa e2e runs: the explore/skip choice from #137 never reaches the user.Since #141 the deliverable Write no longer waits on any answer, so asking is always safe. This is a one-line change to the Silent-prompt branch:
Validated with awos-qa:
product-brownfield-offers-skipandproduct-brownfield-declines-skips-explorationgreen 4× in a row unattended against this branch (they fail against current main); companion QA-side changes in provectus/awos-qa#34.🤖 Generated with Claude Code
https://claude.ai/code/session_01D56dVJjUsoRYEUnxcx3zsH
Summary by CodeRabbit