Skip to content

fix(product): ask the brownfield question even in unattended runs#143

Open
AlexanderMakarov wants to merge 1 commit into
mainfrom
fix/product-brownfield-ask-when-silent
Open

fix(product): ask the brownfield question even in unattended runs#143
AlexanderMakarov wants to merge 1 commit into
mainfrom
fix/product-brownfield-ask-when-silent

Conversation

@AlexanderMakarov

@AlexanderMakarov AlexanderMakarov commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

The silent-prompt brownfield branch of commands/product.md ended with "This question is reached only in an interactive run whose prompt expressed no preference; an unattended run states its choice in the prompt." In practice a model reads that as permission to skip the question and silently pick a default — observed consistently in awos-qa e2e runs: the explore/skip choice from #137 never reaches the user.

Since #141 the deliverable Write no longer waits on any answer, so asking is always safe. This is a one-line change to the Silent-prompt branch:

  • always ask when source-code indicators are found — the sentence carving out session modes is gone; the prompt no longer reasons about interactive vs. unattended at all,
  • exact option labels pinned (models were paraphrasing "No, start from scratch" into "No, from scratch", breaking downstream consumers that key on the documented labels),
  • explicit default when the question goes unanswered (Yes, explore), consistent with the existing INTERACTION rule that an unanswered question is never a stop signal.

Validated with awos-qa: product-brownfield-offers-skip and product-brownfield-declines-skips-exploration green 4× in a row unattended against this branch (they fail against current main); companion QA-side changes in provectus/awos-qa#34.

🤖 Generated with Claude Code

https://claude.ai/code/session_01D56dVJjUsoRYEUnxcx3zsH

Summary by CodeRabbit

  • Documentation
    • Updated the Creation Mode guidance for silent prompts when no preference is provided.
    • If an existing codebase is detected, users are now always asked whether to explore the codebase or start from scratch.
    • If the prompt is left unanswered, the default choice now continues with exploring the codebase.

@coderabbitai

coderabbitai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 092da21a-6ea5-46e8-9301-4f86f118e8e1

📥 Commits

Reviewing files that changed from the base of the PR and between 72b615a and d4fd7c4.

📒 Files selected for processing (1)
  • commands/product.md

📝 Walkthrough

Walkthrough

Updated documentation in commands/product.md revises the Creation Mode brownfield decision logic. The silent prompt branch now always asks via AskUserQuestion with fixed labels when source code indicators are detected, defaulting to "Yes, explore the codebase" if left unanswered.

Changes

Product command documentation update

Layer / File(s) Summary
AskUserQuestion default behavior update
commands/product.md
Instructions now always prompt via AskUserQuestion with fixed option labels when existing source-code indicators are found, defaulting to "Yes, explore the codebase" if unanswered.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • provectus/awos#137: Overlaps with the brownfield-aware Creation Mode flow in commands/product.md, including existing-source detection and user triage.
  • provectus/awos#141: Directly overlaps with handling of unanswered AskUserQuestion defaulting to explore and continuing product file writing.

Suggested reviewers: dustyo-O

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: always asking the brownfield question, including unattended runs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/product-brownfield-ask-when-silent

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…found

The silent-prompt brownfield branch ended with "This question is reached only in an interactive run …; an unattended run states its choice in the prompt" — a model reads that as permission to skip the question and silently pick a default, so the explore/skip choice never reaches the user (observed consistently in awos-qa e2e runs). Since #141 the deliverable Write no longer waits on any answer, so asking is always safe: drop the sentence, make the ask unconditional, pin the exact option labels (models paraphrase otherwise), and give the unanswered case an explicit default (Yes, explore) consistent with the INTERACTION rule that an unanswered question is never a stop signal.

Claude-Session: https://claude.ai/code/session_01D56dVJjUsoRYEUnxcx3zsH
@AlexanderMakarov AlexanderMakarov force-pushed the fix/product-brownfield-ask-when-silent branch from 9e824f5 to d4fd7c4 Compare July 6, 2026 06:17
@AlexanderMakarov AlexanderMakarov marked this pull request as ready for review July 6, 2026 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant