Remove redundant symfony/polyfill-php80 dependency#21
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the symfony/polyfill-php80 dependency from composer.json. Feedback was provided to simplify the version constraints for symfony/finder by removing redundant minor version declarations, as the caret operator already encompasses them.
| "symfony/filesystem": "^5.0 || ^6.0 || ^6.1 || ^6.2", | ||
| "symfony/finder": "^5.0 || ^6.0 || ^6.1 || ^6.2", | ||
| "symfony/polyfill-php80": "^1.24" | ||
| "symfony/finder": "^5.0 || ^6.0 || ^6.1 || ^6.2" |
There was a problem hiding this comment.
The version constraint ^5.0 || ^6.0 || ^6.1 || ^6.2 is redundant. In Composer, the caret operator (^) for a major version (e.g., ^6.0) already includes all subsequent minor and patch releases within that major version (i.e., >=6.0.0 <7.0.0). Therefore, || ^6.1 || ^6.2 does not add any additional versions and can be removed to simplify the requirement. This also applies to the symfony/console and symfony/filesystem dependencies which are not directly modified in this hunk.
| "symfony/finder": "^5.0 || ^6.0 || ^6.1 || ^6.2" | |
| "symfony/finder": "^5.0 || ^6.0" |
This package depends on
symfony/polyfill-php80, but alsophp: >=8.0, so the polyfill requirement doesn't seem necessary anymore?