Skip to content

Remove redundant symfony/polyfill-php80 dependency#21

Open
brendt wants to merge 1 commit into
pronamic:mainfrom
brendt:compat/remove-symfony-polyfill-php80
Open

Remove redundant symfony/polyfill-php80 dependency#21
brendt wants to merge 1 commit into
pronamic:mainfrom
brendt:compat/remove-symfony-polyfill-php80

Conversation

@brendt
Copy link
Copy Markdown

@brendt brendt commented Apr 3, 2026

This package depends on symfony/polyfill-php80, but also php: >=8.0, so the polyfill requirement doesn't seem necessary anymore?

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the symfony/polyfill-php80 dependency from composer.json. Feedback was provided to simplify the version constraints for symfony/finder by removing redundant minor version declarations, as the caret operator already encompasses them.

Comment thread composer.json
"symfony/filesystem": "^5.0 || ^6.0 || ^6.1 || ^6.2",
"symfony/finder": "^5.0 || ^6.0 || ^6.1 || ^6.2",
"symfony/polyfill-php80": "^1.24"
"symfony/finder": "^5.0 || ^6.0 || ^6.1 || ^6.2"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version constraint ^5.0 || ^6.0 || ^6.1 || ^6.2 is redundant. In Composer, the caret operator (^) for a major version (e.g., ^6.0) already includes all subsequent minor and patch releases within that major version (i.e., >=6.0.0 <7.0.0). Therefore, || ^6.1 || ^6.2 does not add any additional versions and can be removed to simplify the requirement. This also applies to the symfony/console and symfony/filesystem dependencies which are not directly modified in this hunk.

Suggested change
"symfony/finder": "^5.0 || ^6.0 || ^6.1 || ^6.2"
"symfony/finder": "^5.0 || ^6.0"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant