feat: enforce repo-agnostic deterministic gates in checkup (#1092)#1107
Open
prompt-driven-github[bot] wants to merge 1 commit into
Open
feat: enforce repo-agnostic deterministic gates in checkup (#1092)#1107prompt-driven-github[bot] wants to merge 1 commit into
prompt-driven-github[bot] wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements a repository-agnostic deterministic gate layer for
pdd checkup --pr --review-loop. This layer ensures that qualitative LLM reviewer verdicts cannot override local hard failures such as syntax errors, linting issues, or whitespace violations.Closes #1092
Changes Made
Prompts Modified
pdd/prompts/commands/checkup_python.prompt- Added--deterministic-gatesCLI flag and threaded it to the orchestrator.pdd/prompts/agentic_checkup_python.prompt- Updated orchestrator signature and dispatcher to handledeterministic_gatesflag.pdd/prompts/checkup_review_loop_python.prompt- Implemented_run_deterministic_gatesrequirement, integrated gate execution before terminal 'clean' states, and added secret scrubbing.pdd/prompts/get_lint_commands_python.prompt- Expanded to support multiple ecosystems (JS/TS, Shell, Go, C++) and addedpy_compilefor Python.Documentation Updated
README.md- Documented the new--deterministic-gatesoption in thecheckupcommand section.Review Checklist
Next Steps After Merge
Created by pdd change workflow