Skip to content

feat: enforce repo-agnostic deterministic gates in checkup (#1092)#1107

Open
prompt-driven-github[bot] wants to merge 1 commit into
mainfrom
change/issue-1092
Open

feat: enforce repo-agnostic deterministic gates in checkup (#1092)#1107
prompt-driven-github[bot] wants to merge 1 commit into
mainfrom
change/issue-1092

Conversation

@prompt-driven-github
Copy link
Copy Markdown
Contributor

Summary

This PR implements a repository-agnostic deterministic gate layer for pdd checkup --pr --review-loop. This layer ensures that qualitative LLM reviewer verdicts cannot override local hard failures such as syntax errors, linting issues, or whitespace violations.

Closes #1092

Changes Made

Prompts Modified

  • pdd/prompts/commands/checkup_python.prompt - Added --deterministic-gates CLI flag and threaded it to the orchestrator.
  • pdd/prompts/agentic_checkup_python.prompt - Updated orchestrator signature and dispatcher to handle deterministic_gates flag.
  • pdd/prompts/checkup_review_loop_python.prompt - Implemented _run_deterministic_gates requirement, integrated gate execution before terminal 'clean' states, and added secret scrubbing.
  • pdd/prompts/get_lint_commands_python.prompt - Expanded to support multiple ecosystems (JS/TS, Shell, Go, C++) and added py_compile for Python.

Documentation Updated

  • README.md - Documented the new --deterministic-gates option in the checkup command section.

Review Checklist

  • Prompt syntax is valid
  • PDD conventions followed
  • Documentation is up to date

Next Steps After Merge

  1. Regenerate code from modified prompts in dependency order:
    ./sync_order.sh
    Or manually:
    pdd sync get_lint_commands
    pdd sync split_validation
    pdd sync checkup
    pdd sync checkup_review_loop
    pdd sync agentic_checkup
    
  2. Run tests to verify functionality
  3. Deploy if applicable

Created by pdd change workflow

Copy link
Copy Markdown

@greptile-apps greptile-apps Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pdd checkup --pr should enforce repo-agnostic deterministic gates before clean verdict

0 participants