Fix: preserve --protect-tests during agentic fallback#1085
Open
imradawoodani wants to merge 3 commits into
Open
Fix: preserve --protect-tests during agentic fallback#1085imradawoodani wants to merge 3 commits into
imradawoodani wants to merge 3 commits into
Conversation
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
Contributor
|
target 5/21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #771
What changed
tests/test_fix_error_loop.pyto ensureprotect_tests=Trueis forwarded into the agentic fallback helper.pdd/pdd/fix_error_loop.pyso_safe_run_agentic_fix()acceptsprotect_testsand every fallback path passes it through torun_agentic_fix().Why
When
pdd fix --loop --protect-testsfalls back to agentic mode, theflag was previously dropped and the fallback agent could modify tests.
This fix preserves the user’s intent and prevents test files from being
edited during agentic fallback.
Testing
export PDD_PATH=$(pwd)pytest -q tests/test_fix_error_loop.py -k protect_testspytest -q tests/test_fix_error_loop.py