feat: share one drift classifier across sync/update/change/CI (#884)#1027
Open
prompt-driven-github[bot] wants to merge 1 commit into
Open
feat: share one drift classifier across sync/update/change/CI (#884)#1027prompt-driven-github[bot] wants to merge 1 commit into
prompt-driven-github[bot] wants to merge 1 commit into
Conversation
…t, and CI auto-heal (#884) Introduce a shared, pure drift classifier and wire the five existing classification paths (sync_determine_operation, pdd update --all, CI auto-heal, pdd change preflight, no-arg pdd sync Tier 1 scan) to build DriftInputs and consume a structured DriftVerdict. Repair plans remain command-specific in this first PR; only classification is unified. Closes #884 Co-Authored-By: Claude Opus 4 <noreply@anthropic.com>
There was a problem hiding this comment.
Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Introduces a shared, pure drift classifier (
pdd/drift_classifier.py, defined by a new prompt) and wires the five existing artifact-drift classification paths to build a commonDriftInputsand consume a structuredDriftVerdict. Repair plans remain command-specific in this first PR — only the classification step is unified.Closes #884
Changes Made
Prompts Created
pdd/prompts/drift_classifier_python.prompt— new pure classifier prompt; Pydantic v2DriftInputs/DriftVerdict, enumeratedDriftReason, git diff as an explicit input field (not a CI-only correction).Prompts Modified
pdd/prompts/sync_determine_operation_python.prompt— buildsDriftInputs, callsclassify_drift, maps verdict onto the existing fingerprint state machine.pdd/prompts/update_main_python.prompt—pdd update --allpath now constructsDriftInputs(includinggit_change_set) and calls the shared classifier.pdd/prompts/ci_drift_heal_python.prompt— CI auto-heal passes its git diff in asgit_change_set; drops the post-hoc reclassification branch.pdd/prompts/agentic_change_orchestrator_python.prompt—pdd changepreflight callsclassify_driftto decide whether to heal.pdd/prompts/sync_main_python.prompt— no-argpdd syncTier 1 global scan classifies each module through the shared classifier.Documentation Created
docs/drift_classifier.md— design doc / module-level API sketch (satisfies acceptance criterionpdd install_completion:install_completion()got unexpected keyword argument 'quiet' #1).Other
architecture.json— registers the newdrift_classifiermodule.Review Checklist
sync_determine_operation, CI auto-heal, and change preflight (per acceptance criterion Claude-3-5-Haiku outputting code in structured json format #4)Next Steps After Merge
Created by pdd change workflow