#3510 resolved#3713
Conversation
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Throw an error if Mailgun key is missing instead of warning.
yugalkaushik
left a comment
There was a problem hiding this comment.
@VatsalCodes44 Hi please go through the contribution guidelines for translation related contributions. https://github.com/processing/p5.js-web-editor/blob/develop/contributor_docs/translations.md , for translation only translate languages you speak fluently or natively. I reviewed your PR and some changes are unnecessary and require no changes so please revisit them.
|
Thanks so much for your interest in this issue! Adding on to the review above, we generally want to ensure changes are also more compact and touch a specific area or few files at a time for easier review (i.e in this case, probably one language that you speak). Since quite a bit of time has passed since this was last open and this PR doesn't meet some of the guidelines for translations, I'm going to close this for now. I'm sorry that we couldn't get this in, but please feel free to reopen this with more granular changes or check out our other issues! |
Fixes #3510
Changes:
SubmitSaveAllSettingskey withSaveAccountDetailsacross all languagesSettingscontext in AccountView to consistently display "My Account" equivalentI have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #3510