fix(ci): Fix sign error - #303
Merged
Merged
Conversation
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the release GitHub Actions workflow to stop invoking a non‑existent Gradle 'sign' task by removing it from the release publishing command and adjusting the step label accordingly. Flow diagram for updated CI release publish stepflowchart LR
A[GitHub_Actions_release_job] --> B[Checkout_and_setup_gradle_properties]
B --> C[Run_gradle_publish_commands]
C -->|./gradlew publish publishToMavenCentral| D[Artifacts_published_to_MavenCentral]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since you've removed the signing step, consider also dropping the
GPG_TTYenvironment variable from this job as it is no longer used and can be misleading for future maintainers. - The
cat gradle.propertiesline will print Nexus credentials into the GitHub Actions logs; it would be safer to remove this or limit output to non-secret information to avoid leaking sensitive data.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since you've removed the signing step, consider also dropping the `GPG_TTY` environment variable from this job as it is no longer used and can be misleading for future maintainers.
- The `cat gradle.properties` line will print Nexus credentials into the GitHub Actions logs; it would be safer to remove this or limit output to non-secret information to avoid leaking sensitive data.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
msmygit
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the CI error:
Tested with(401 is as expected since no token there) :https://github.com/unix280/tempto/actions/runs/27118238373/job/80029399433