Skip to content

fix(ci): Fix sign error - #303

Merged
unidevel merged 1 commit into
prestodb:masterfrom
unidevel:fix-sign
Jun 8, 2026
Merged

fix(ci): Fix sign error#303
unidevel merged 1 commit into
prestodb:masterfrom
unidevel:fix-sign

Conversation

@unidevel

@unidevel unidevel commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Fix the CI error:

FAILURE: Build failed with an exception.

Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
* What went wrong:

Task 'sign' not found in root project 'tempto' and its subprojects.
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

Tested with(401 is as expected since no token there) :https://github.com/unix280/tempto/actions/runs/27118238373/job/80029399433

@sourcery-ai

sourcery-ai Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the release GitHub Actions workflow to stop invoking a non‑existent Gradle 'sign' task by removing it from the release publishing command and adjusting the step label accordingly.

Flow diagram for updated CI release publish step

flowchart LR
    A[GitHub_Actions_release_job] --> B[Checkout_and_setup_gradle_properties]
    B --> C[Run_gradle_publish_commands]
    C -->|./gradlew publish publishToMavenCentral| D[Artifacts_published_to_MavenCentral]
Loading

File-Level Changes

Change Details Files
Adjust release CI workflow to no longer call the missing Gradle 'sign' task.
  • Rename the release publishing step to remove reference to signing.
  • Update the Gradle command to drop the 'sign' task while still running 'publish' and 'publishToMavenCentral'.
  • Keep Nexus credentials and environment setup unchanged while modifying only the invoked Gradle tasks.
.github/workflows/release.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Since you've removed the signing step, consider also dropping the GPG_TTY environment variable from this job as it is no longer used and can be misleading for future maintainers.
  • The cat gradle.properties line will print Nexus credentials into the GitHub Actions logs; it would be safer to remove this or limit output to non-secret information to avoid leaking sensitive data.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since you've removed the signing step, consider also dropping the `GPG_TTY` environment variable from this job as it is no longer used and can be misleading for future maintainers.
- The `cat gradle.properties` line will print Nexus credentials into the GitHub Actions logs; it would be safer to remove this or limit output to non-secret information to avoid leaking sensitive data.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@unidevel
unidevel requested review from msmygit and wanglinsong June 8, 2026 05:45
@unidevel
unidevel merged commit 140615d into prestodb:master Jun 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants