Check for integer wrapping in getrootlength_new#4
Open
sotlampr wants to merge 1 commit intopredictivephenomics:mainfrom
Open
Check for integer wrapping in getrootlength_new#4sotlampr wants to merge 1 commit intopredictivephenomics:mainfrom
sotlampr wants to merge 1 commit intopredictivephenomics:mainfrom
Conversation
sotlampr
commented
Oct 31, 2025
| segmentsize = simplified.size(); | ||
|
|
||
| for (int j = 0; j < segmentsize; j++) | ||
| if (segmentsize == 0) |
Author
There was a problem hiding this comment.
Probably this should be <=1, as we access simplified[j+1] in the loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the inner loop, if
simplified.size() == 0thensegmentsize = simplified.size()-1wraps around to max int. Subsequently we enter the loop with thej < segmentsizecondition and get a segmentation fault .This PR skips the inner loop altogether if
simplified.size() == 0.