Module update: LI EID permissions #4315
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marki1an
requested review from
And1sS and
CTMBNara
and removed request for
And1sS
osulzhenko
changed the title
CTMBNara
requested changes
Jan 5, 2026
|
|
||
| private BidRequest updateAllowedBidders(BidRequest bidRequest, List<Eid> resolvedEids) { | ||
| if (targetBidders.isEmpty()) { | ||
| if (targetBidders.isEmpty() || resolvedEids == null || resolvedEids.isEmpty()) { |
Collaborator
There was a problem hiding this comment.
Use CollectionUtils.isEmpty instead
Comment on lines
+209
to
+215
| final List<ExtRequestPrebidDataEidPermissions> existingPerms = extPrebidData != null | ||
| ? ListUtils.emptyIfNull(extPrebidData.getEidPermissions()) | ||
| : List.of(); | ||
|
|
||
| if (existingPerms.isEmpty()) { | ||
| return bidRequest; | ||
| } |
Collaborator
There was a problem hiding this comment.
final List<ExtRequestPrebidDataEidPermissions> eidPermissions = extPrebidData != null ? extPrebidData.getEidPermissions() : null;
if (CollectionUtils.isEmpty(eidPermissions)) {
return bidRequest;
}
| resolvedSources.stream() | ||
| .map(source -> ExtRequestPrebidDataEidPermissions.of(source, targetBidders))) | ||
| .filter(StreamUtil.distinctBy(ExtRequestPrebidDataEidPermissions::getSource)) | ||
| .orElse(List.of()); |
Collaborator
There was a problem hiding this comment.
List.of -> Collections.emptyList()
Comment on lines
+257
to
259
| final List<String> current = ListUtils.emptyIfNull(permission.getBidders()); | ||
| final List<String> finalBidders = ListUtils.intersection(current, targetBidders); | ||
|
|
Collaborator
There was a problem hiding this comment.
Make targetBidders a set. If possible, do the same for permission.getBidders().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Type of changes
✨ What's the context?
Properly handling EID permissions in LiveIntent module
🧠 Rationale behind the change
Why did you choose to make these changes? Were there any trade-offs you had to consider?
🔎 New Bid Adapter Checklist
🧪 Test plan
How do you know the changes are safe to ship to production?
🏎 Quality check