Validate conflicting declaration specifiers (e.g. long short int) - #111
Merged
praeclarum merged 2 commits intoMar 31, 2026
Merged
Conversation
… int) Validate size specifier combinations in EmitContext.MakeCType(): - Reject invalid combinations like "long short", "short short" - Reject size modifiers with float and bool types - Reject "short" with double (only "long double" is valid) - Report error 2078 for invalid combinations Add tests for all invalid combinations and valid edge cases. Agent-Logs-Url: https://github.com/praeclarum/CLanguage/sessions/89ed26c4-8632-4e43-a058-f53924ce4c90 Co-authored-by: praeclarum <323548+praeclarum@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix validation of conflicting declaration specifiers
Validate conflicting declaration specifiers (e.g. Mar 31, 2026
long short int)
praeclarum
marked this pull request as ready for review
March 31, 2026 20:25
praeclarum
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MakeCType()silently concatenated size specifiers ("long" + "short"→"long short"), andCIntTypeaccepted the garbage string without complaint.Changes
EmitContext.cs: After collecting size specifiers, validate the result is one of"","short","long","long long". Also reject size modifiers onfloat/bool, andshort double(while allowinglong double). Reports error 2078.DeclarationTests.cs: 10 new tests covering invalid combos (long short int,short float,short double,long bool, etc.) and valid edge cases (long double,long long int).