Skip to content

Fix array initializer type casting and multidimensional array initialization - #110

Merged
praeclarum merged 2 commits into
masterfrom
copilot/fix-int-array-initialization
Mar 31, 2026
Merged

Fix array initializer type casting and multidimensional array initialization#110
praeclarum merged 2 commits into
masterfrom
copilot/fix-int-array-initialization

Conversation

Copilot AI commented Mar 31, 2026

Copy link
Copy Markdown
Contributor

int arr[2] = {2.0f, 3.0f} silently produces zeroes because DoEmitStructureAssignment emits initializer values without casting to the target element type. Multidimensional array init (int a[2][3] = {{1,2,3},{4,5,6}}) also fails because the read path unconditionally dereferences element pointers even when the element is itself an array.

Changes

  • AssignExpression.cs — Add EmitCast from each item's type to the array element type. Extract recursive EmitArrayStructuredInit to walk nested StructureExpression nodes for multidimensional arrays.
  • ArrayElementExpression.cs — Skip LoadPointer when the evaluated element type is CArrayType (array-to-pointer decay instead of value load).
  • ArrayTests.cs — Tests for float→int, double→int, int→float array init, and 2D array init (global + local).
// Previously: arr[0] == 0, arr[1] == 0 (float bits stored as int)
// Now: arr[0] == 2, arr[1] == 3 (proper truncation)
int arr[2] = {2.0f, 3.0f};

// Previously: not supported
// Now: works correctly
int a[2][3] = {{1, 2, 3}, {4, 5, 6}};

…t support

- Add EmitCast in DoEmitStructureAssignment to cast each element to the
  array's element type (fixes #39: float-to-int array init)
- Add recursive EmitArrayStructuredInit for nested StructureExpression
  items to support multidimensional array initialization (fixes #46)
- Fix ArrayElementExpression.DoEmit to skip LoadPointer when element
  type is CArrayType (array-to-pointer decay for multidimensional reads)
- Add tests for float/double-to-int, int-to-float, and 2D array init

Agent-Logs-Url: https://github.com/praeclarum/CLanguage/sessions/b190017e-c781-4532-ba81-cb23a4dcacda

Co-authored-by: praeclarum <323548+praeclarum@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix array initializer with float values producing incorrect int values Fix array initializer type casting and multidimensional array initialization Mar 31, 2026
Copilot AI requested a review from praeclarum March 31, 2026 20:13
@praeclarum
praeclarum marked this pull request as ready for review March 31, 2026 20:32
@praeclarum
praeclarum merged commit 653dc73 into master Mar 31, 2026
1 check passed
@praeclarum
praeclarum deleted the copilot/fix-int-array-initialization branch March 31, 2026 20:35
@praeclarum praeclarum mentioned this pull request Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Array initializer with float values silently produces wrong int values

2 participants